test: Add test for "needCheckForUpdates" #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanishiking
force-pushed
the
test-need-check-update
branch
2 times, most recently
from
13a5e45 to
8e5cbdb
Compare
tanishiking
force-pushed
the
test-need-check-update
branch
from
8e5cbdb to
57e701d
Compare
5 tasks
|
It's awesome that you're trying to tackle this @tanishiking. I'll have a look at it later today ;) |
|
thanks! I'll open a PR against scalameta :) |
|
One problem with |
tanishiking
force-pushed
the
test-need-check-update
branch
from
57e701d to
a2f1cd1
Compare
scalameta#1144 This commit adds a test for `needCheckForUpdates`. For adding unit tests, this commit abstract away the logic that needs access to vscode APIs, becuase we need to run an integration test for accessing vscode APIs. see: microsoft/vscode-wordcount#5 (comment) microsoft/vscode#82471 (comment)
tanishiking
force-pushed
the
test-need-check-update
branch
from
a2f1cd1 to
da8ac81
Compare
tanishiking
force-pushed
the
test-need-check-update
branch
from
cf2862e to
8c28bbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a test for
needCheckForUpdates.(because, even though
metals-vscodehas a complicated logic, it lacksunit-tests to verify the behaviors).
For adding unit tests, this commit abstract away the logics that need
an access to vscode APIs, becuase we need to run integration test for
accessing vscode APIs.
see: microsoft/vscode-wordcount#5 (comment)
microsoft/vscode#82471 (comment)